Symbols: Add GenericArguments to FSharpEntity
#16470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
T-Gro
approved these changes
Jan 3, 2024
edgarfgp
approved these changes
Jan 15, 2024
|
This is ready. |
vzarytovskii
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #16456. It adds a public API for getting type arguments from resolved
FSharpEntityitems, so type arguments are accessible in cases like this:The new API is not perfectly aligned with a similar one in
FSharpSymbolUse, and I'm still thinking about ways to unify them. For now this seems to work good enough, and I'd like to make it available for use in the meanwhile.