Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track PostTypeCheckSemanticChecks.CheckImplFile activity. #16528

Merged
merged 2 commits into from Jan 15, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 15, 2024

Description

Related to #14429.
While playing around with https://gist.github.com/nojaf/b9f642eec283482fc720ac9cac95e9af to find out what could be improved, it was interesting to see that PostInference takes more time than the type-checking. (For this single example of course)

image

I'd like to track PostTypeCheckSemanticChecks.CheckImplFile in the future.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf nojaf requested a review from a team as a code owner January 15, 2024 13:12
@nojaf nojaf added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jan 15, 2024
Copy link
Contributor

github-actions bot commented Jan 15, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii vzarytovskii merged commit c980a10 into dotnet:main Jan 15, 2024
6 of 26 checks passed
@vzarytovskii
Copy link
Member

Thanks, that's nice to have more activity events!

@vzarytovskii
Copy link
Member

Wondering if when we building compiler with Proto compiler, we can automatically collect statistics and attach it to PR via comment. Will it be helpful?

@T-Gro
Copy link
Member

T-Gro commented Jan 22, 2024

An invokable GH action would be nice, for timing the self-built.
The --times output was already adjusted to be markdown, and I think we could sneak in some markers to make it better grep-able if it isn't already out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants