Fix16431 - Modify DU static initialization #16661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
nojaf
reviewed
Feb 7, 2024
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
T-Gro
reviewed
Feb 7, 2024
tests/FSharp.Compiler.ComponentTests/Conformance/Types/UnionTypes/UnionTypes.fs
Show resolved
Hide resolved
T-Gro
approved these changes
Feb 7, 2024
psfinaki
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16431
There is a bug with DU initialization, that causes the DU ID for each type to be initialized after all of the remainder of the static initialization.
The fix is to ensure that we provoke the static initialization code in the .cctor for the DUafter the unique ids have been assigned.
The PR for static initialization will need to be updated to reflect this new behavior.
This is not actually a breaking change, so we will treat it as a bug fix.