Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #30: Compilation error "Incorrect number of type arguments to local call" #167

Closed
wants to merge 3 commits into from

Conversation

andrewjkennedy
Copy link

Code was comparing a pre-erasure list of arguments with a post-erasure list

Code was comparing a pre-erasure list of arguments with a post-erasure list
@dsyme
Copy link
Contributor

dsyme commented Jan 28, 2015

This looks good. I guess we will need to add a test too.

@andrewjkennedy
Copy link
Author

Added test

@andrewjkennedy andrewjkennedy changed the title Fix for https://github.com/Microsoft/visualfsharp/issues/30 Fix for issue #30: Compilation error "Incorrect number of type arguments to local call" Jan 29, 2015
@dsyme
Copy link
Contributor

dsyme commented Jan 29, 2015

Hi Andrew, ignore the AppVeyor failure. If you push another commit in, you should see it run and hopefully succeed

@andrewjkennedy
Copy link
Author

Yep, just did that!

Any more?...

A

From: Don Syme [mailto:notifications@github.com]
Sent: 29 January 2015 10:14
To: Microsoft/visualfsharp
Cc: Andrew Kennedy
Subject: Re: [visualfsharp] Fix for issue #30: Compilation error "Incorrect number of type arguments to local call" (#167)

Hi Andrew, ignore the AppVeyor failure. If you push another commit in, you should see it run and hopefully succeed


Reply to this email directly or view it on GitHubhttps://github.com//pull/167#issuecomment-72000365.

@dsyme
Copy link
Contributor

dsyme commented Jan 29, 2015

I don't see the extra commit (just the second test commit, but AppVeyor wasn't et up when you pushed that one)

@latkin latkin closed this in 9ca869d Jan 30, 2015
@latkin latkin added the fixed label Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants