Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 13926 - Disallow using base to invoke an abstract base method. #16773

Merged
merged 6 commits into from Mar 5, 2024
Merged

Fix 13926 - Disallow using base to invoke an abstract base method. #16773

merged 6 commits into from Mar 5, 2024

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Feb 27, 2024 •
edited by psfinaki

Fixes #13926

@KevinRansom KevinRansom requested a review from a team as a code owner February 27, 2024 01:54
@KevinRansom KevinRansom marked this pull request as draft February 27, 2024 01:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@KevinRansom KevinRansom changed the title Fix 13926 Fix 13926 - Disallow using base to invoke an abstract base method. Feb 27, 2024
@KevinRansom KevinRansom force-pushed the Fix13926 branch 2 times, most recently from 748b582 to c365552 Compare March 5, 2024 01:02
@KevinRansom KevinRansom marked this pull request as ready for review March 5, 2024 08:45
T-Gro
T-Gro reviewed Mar 5, 2024
View reviewed changes
src/Compiler/AbstractIL/il.fs Outdated Show resolved Hide resolved
KevinRansom and others added 4 commits March 5, 2024 02:13
@KevinRansom @T-Gro
Update src/Compiler/AbstractIL/il.fs
2158719 
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
@KevinRansom @T-Gro
Update src/Compiler/FSharp.Compiler.Service.fsproj
ee233b9 
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
@KevinRansom
Merge branch 'main' into Fix13926
1f2dede
@psfinaki
Update 8.0.md
bd6296c
@psfinaki psfinaki enabled auto-merge (squash) March 5, 2024 12:01
@psfinaki psfinaki merged commit d73bb4b into dotnet:main Mar 5, 2024
31 checks passed
@dotnet-bot dotnet-bot mentioned this pull request Mar 12, 2024
Closed
@KevinRansom KevinRansom deleted the Fix13926 branch March 21, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BadImageFormatException : Bad IL format when using base
4 participants
@KevinRansom @psfinaki @edgarfgp @T-Gro