Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong range start of INTERP_STRING_END #16774

Merged
merged 3 commits into from Feb 27, 2024
Merged

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Feb 27, 2024

Description

Ain't nothing pretty here.
It tries to fix the somewhat long-standing issue of the wrong range start of INTERP_STRING_END

Fixes #16418

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@dawedawe dawedawe requested a review from a team as a code owner February 27, 2024 10:42
Copy link
Contributor

github-actions bot commented Feb 27, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@psfinaki psfinaki merged commit 2e95cbc into dotnet:main Feb 27, 2024
29 checks passed
@psfinaki
Copy link
Member

Thanks Dave :)

psfinaki pushed a commit that referenced this pull request Feb 28, 2024
* Fix 16105 - Release inline optimization leads to MethodAccessException if used with assembly:InternalsVisibleTo attribute (#16737)

* Fix16105

* trimming

* Update release notes

---------

Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

* fix wrong range start of INTERP_STRING_END (#16774)

* fix wrong range start of INTERP_STRING_END

* add release notes entry

---------

Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>

* Update dependencies from https://github.com/dotnet/arcade build 20240223.1 (#16776)

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24113.2 -> To Version 8.0.0-beta.24123.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>

* remove superseded test of TryGetRecentCheckResultsForFile (#16770)

* remove superseded test of TryGetRecentCheckResultsForFile

* kick CI

* Allow e2e tests to fail for now

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20240227.2 (#16777)

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24123.3 -> To Version 9.0.0-alpha.1.24127.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

---------

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: dawe <dawedawe@posteo.de>
Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect range for SynInterpolatedStringPart.String in extended interpolated string
4 participants