Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion: don't prevent getting items after record definition #16813

Merged
merged 5 commits into from Mar 12, 2024

Conversation

auduchinok
Copy link
Member

Fixes broken code completion after a record type declaration:

type R =
    { F: int }

{caret}

@auduchinok auduchinok requested a review from a team as a code owner March 5, 2024 14:24
Copy link
Contributor

github-actions bot commented Mar 5, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@psfinaki
Copy link
Member

psfinaki commented Mar 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member

psfinaki commented Mar 6, 2024

Some tests for this? :)

As of now, I don't entirely understand what's broken and what's changing.

image

@majocha
Copy link
Contributor

majocha commented Mar 6, 2024

@psfinaki , try with cursor outside or below of curly brackets after the declaration. However, once you start typing, completions do show up after one letter.

@auduchinok
Copy link
Member Author

As of now, I don't entirely understand what's broken and what's changing.

There're no F# symbols from FCS when pressing Ctrl+Space after the type decl:

Screenshot 2024-03-06 at 09 39 17

@psfinaki
Copy link
Member

psfinaki commented Mar 6, 2024

Oh alright I see, thanks for pointing out.
Okay but still we should probably have some tests for it :-P

@vzarytovskii vzarytovskii enabled auto-merge (squash) March 12, 2024 09:52
@vzarytovskii
Copy link
Member

Will auto-merge as soon as comments are resolved

@vzarytovskii vzarytovskii merged commit be658c5 into dotnet:main Mar 12, 2024
32 checks passed
@auduchinok auduchinok deleted the completion-recdDefn branch March 12, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants