Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: fix pattern range for idents with trivia #16824

Merged
merged 6 commits into from Mar 12, 2024

Conversation

auduchinok
Copy link
Member

@auduchinok auduchinok commented Mar 6, 2024

Fixes wrong ranges for patterns that contain identifiers with trivia.

Here the parens are not considered a part of the pattern, which results in a wrong pattern range:

let (|A|) = ()

Here the error expression from the recovery rule is placed between | and ) instead of after ):

let (|A|)

@auduchinok auduchinok requested a review from a team as a code owner March 6, 2024 20:15
Copy link
Contributor

github-actions bot commented Mar 6, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vzarytovskii vzarytovskii enabled auto-merge (squash) March 12, 2024 09:57
Copy link
Contributor

Caution

Repository is on lockdown for maintenance, all merges are on hold.

@vzarytovskii vzarytovskii merged commit 9669913 into dotnet:main Mar 12, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants