Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: more 'as' pattern recovery #16837

Merged
merged 3 commits into from Mar 18, 2024
Merged

Parser: more 'as' pattern recovery #16837

merged 3 commits into from Mar 18, 2024

Conversation

auduchinok
Copy link
Member

More recovery for cases like this:

match a with
| _ as

()

@auduchinok auduchinok requested a review from a team as a code owner March 7, 2024 21:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

psfinaki
psfinaki approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks Eugene.

@auduchinok
Copy link
Member Author

This is ready.

@psfinaki psfinaki enabled auto-merge (squash) March 18, 2024 18:16
@psfinaki psfinaki merged commit 6b7aa6e into dotnet:main Mar 18, 2024
32 checks passed
@auduchinok auduchinok deleted the parser-pat-as branch March 19, 2024 17:21
@dotnet-bot dotnet-bot mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@auduchinok @psfinaki @abonie