Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker/patterns: recover on unresolved long identifiers #16842

Merged
merged 7 commits into from Mar 22, 2024

Conversation

auduchinok
Copy link
Member

Adds recovery for unresolved long identifiers in patterns, which fixes missing analysis in cases like this:

Screenshot 2024-02-16 at 14 49 14

@auduchinok auduchinok requested a review from a team as a code owner March 8, 2024 16:37
Copy link
Contributor

github-actions bot commented Mar 8, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thank you.

tests/service/PatternMatchCompilationTests.fs Outdated Show resolved Hide resolved
@abonie
Copy link
Member

abonie commented Mar 11, 2024

@auduchinok , could you please add release note in docs/release-notes/.FSharp.Compiler.Service/8.0.300.md if this affects user experience (I believe it does?)

@vzarytovskii vzarytovskii enabled auto-merge (squash) March 12, 2024 09:58
auto-merge was automatically disabled March 13, 2024 17:46

Head branch was pushed to by a user without write access

@psfinaki
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants