Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Beforecompile" #17099

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Revert "Beforecompile" #17099

merged 1 commit into from
Apr 29, 2024

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Apr 29, 2024

Reverts #17057, it breaks plain build:

FSC : error FS0193: The module/namespace 'Microsoft.FSharp.Core' from compilation unit 'FSharp.Core' did not contain the namespace, module or type 'int64' [/Users/runner/work/1/s/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.0]
FSC : error FS0193: The module/namespace 'Microsoft.FSharp.Core' from compilation unit 'FSharp.Core' did not contain the namespace, module or type 'string' [/Users/runner/work/1/s/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.0]
FSC : error FS0193: The module/namespace 'Microsoft.FSharp.Core' from compilation unit 'FSharp.Core' did not contain the namespace, module or type 'int64' [/Users/runner/work/1/s/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.0]
FSC : error FS0193: The module/namespace 'Microsoft.FSharp.Core' from compilation unit 'FSharp.Core' did not contain the namespace, module or type 'string' [/Users/runner/work/1/s/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.0]
FSC : error FS0193: The module/namespace 'Microsoft.FSharp.Core' from compilation unit 'FSharp.Core' did not contain the namespace, module or type 'int64' [/Users/runner/work/1/s/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.0]
FSC : error FS0193: The module/namespace 'Microsoft.FSharp.Core' from compilation unit 'FSharp.Core' did not contain the namespace, module or type 'string' [/Users/runner/work/1/s/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.0]
FSC : error FS0193: The module/namespace 'Microsoft.FSharp.Core' from compilation unit 'FSharp.Core' did not contain the namespace, module or type 'int64' [/Users/runner/work/1/s/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.0]
FSC : error FS0193: The module/namespace 'Microsoft.FSharp.Core' from compilation unit 'FSharp.Core' did not contain the namespace, module or type 'string' [/Users/runner/work/1/s/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.0]
 

https://dev.azure.com/dnceng-public/public/_build/results?buildId=657428&view=logs&j=21ffccb3-dd24-5c7d-bf5b-5230b6605867&t=15059643-aeb2-5260-2074-e0b8d6154b00

It blocks most external maintainers (myself as well, since I use plain build).

@vzarytovskii vzarytovskii requested a review from a team as a code owner April 29, 2024 11:41
Copy link
Contributor

github-actions bot commented Apr 29, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 29, 2024
@vzarytovskii vzarytovskii enabled auto-merge (squash) April 29, 2024 11:46
@vzarytovskii
Copy link
Member Author

Something must've changed in ordering, since it seems prelude is not compiled first anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants