Fix colorization speed in large files #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes glyphs: #1806. Public/private/protected is not yet propagated to the glyph but this gives us feature parity with VS2015
|
This was referenced Nov 24, 2016
|
@OmarTawfik I'm merging this since it's solid and fast when I've been using it, please review. |
|
@dsyme thanks for taking care of this! |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Fixes dotnet#1821 Incremental colorization was not being effective on changing files for a number of reasons •Data cache was keyed by source text rather than document ID •We were writing None entries right through to end-of-file even when we could stop earlier •We weren't checking that start-of-line indexes and lex states were still the same when reusing entries •Tokenizers getting recreated for each line - we can cache these as well. I've tried the PR out on large files and it works much more efficiently. Also a fix to make ShouldTriggerCompletionAux faster in the common case where not pressing . This also fixes glyphs: dotnet#1806. Public/private/protected is not yet propagated to the glyph but this gives us feature parity with VS2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1821
Incremental colorization was not being effective on changing files for a number of reasons
I've tried the PR out on large files and it works much more efficiently.
Also a fix to make
ShouldTriggerCompletionAuxfaster in the common case where not pressing.