Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: try to fix record init order bug described in #212 #214

Closed
wants to merge 2 commits into from

Conversation

forki
Copy link
Contributor

@forki forki commented Feb 4, 2015

This is WIP!

I'm analyzing #212 and

  • rebased this on Run Compiler tests in AppVeyor #215
  • created a test which fails
  • created an oversimplified fix to see what else breaks
    • it fixes the test, but currently breaks compilation of other projects

@forki forki force-pushed the recinit branch 5 times, most recently from c0d8b4d to d2e736f Compare February 4, 2015 16:18
@forki forki force-pushed the recinit branch 2 times, most recently from 882d3c0 to d922c48 Compare February 4, 2015 17:37
@forki forki changed the title WIP: Add a failing test for #212 WIP: try to fix record init order bug described in #212 Feb 4, 2015
@forki
Copy link
Contributor Author

forki commented Feb 4, 2015

Ok my "fix" in f3f91f1 revealed something very strange:

image

this warning pops up after the proto-compiler is built with f3f91f1 and sounds correct to me?!

@latkin @dsyme @KevinRansom

tumblr_inline_mzberrdg6n1raprkq

@forki
Copy link
Contributor Author

forki commented Feb 4, 2015

after adding #nowarn "40" I get

image

which seems unintended since we have a rec keyword.

@KevinRansom
Copy link
Member

Hey Steffen, this is looking promising but has languished for almost a month now. Closing it for now, but please raise issues for the items, you think are bugs or need attention before you can progress with this. Feel free to resubmit this when you think it is ready.

@KevinRansom KevinRansom closed this Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants