Port a test from Paket over to FSharp.Core tests #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok it seems to work on master. |
|
Mhm it also seems to work against the 4.2.1 branch. I'm lost |
|
Correspondign Paket branch: fsprojects/Paket#2553 |
|
Ok it clearly hangs in paket when we update fsharp.core. |
|
Ok so it seems that it's not test what's hanging. I commented that test out from paket's test suite and it's still hanging. So I still believe the new fsharp.core is flawed, but not with this test here. @matthid and myself will investigate further. Anyway @KevinRansom please feel free to merge this test here. It's good to have it in the code base. |
cartermp
approved these changes
Jul 21, 2017
KevinRansom
approved these changes
Jul 22, 2017
|
@forki |
matthid
added a commit
to matthid/visualfsharp
that referenced
this pull request
Jul 24, 2017
matthid
added a commit
to matthid/visualfsharp
that referenced
this pull request
Jul 24, 2017
dsyme
pushed a commit
that referenced
this pull request
Jul 25, 2017
* add another test for #3254, ported from paket. related to #3350 and fsprojects/Paket#2553 * Fix exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added to Paket by @Thorium in August 2016 and worked up to FSharp.Core 4.1.17 but hangs in 4.2.1.
/cc @eiriktsarpalis @dsyme @matthid @Thorium