Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for easy DesignTime Assembly Packing #4239

Merged
merged 3 commits into from Jan 23, 2018

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Jan 23, 2018

Type providers may be split into two portions a runtime helpers library and a design time library to run in the compiler/fcs/fsi etc ...

This PR makes dotnet pack easier.

Example projects:

This Example consists of a runtime project a design time project
The design time project is a project reference it is tagged with:

      <IsFSharpDesignTimeProvider>true</IsFSharpDesignTimeProvider>
      <PrivateAssets>all</PrivateAssets>

Private Assets, stops the build and nuget from making the DesignTime assembly a dependency of the package.

The package layout conforms to : #3864

However, nuget doesn't make make specific target runtimes subdirectories of the TargetFramework, so neither does this. nugget uses the runtime branch for runtime specific probing.

I propose revising the current probing logic to stop probing for x86 and x64.

Additionally:

  • DesignTime Assemblies will cover extensions other than TypeProviders moving forward.
  • 'typeproviders' causes nuget packaging warnings

The default here is to place designtime assemblies below tool. To place them below typeproviders
use:

<FSharpToolsDirectory>typeproviders</<FSharpToolsDirectory>
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFrameworks>net461;netstandard2.0</TargetFrameworks>
  </PropertyGroup>

  <ItemGroup>
    <Compile Include="BasicProvider.Runtime.fs" />
  </ItemGroup>

  <ItemGroup>
    <ProjectReference Include="..\BasicProvider.DesignTime\BasicProvider.DesignTime.fsproj">
      <IsFSharpDesignTimeProvider>true</IsFSharpDesignTimeProvider>
      <PrivateAssets>all</PrivateAssets>
    </ProjectReference>
  </ItemGroup>

</Project>


@KevinRansom KevinRansom merged commit 6cb64f2 into dotnet:master Jan 23, 2018
@KevinRansom KevinRansom deleted the typeproviderpack branch August 2, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant