Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build nuget packages after signing #4269

Merged
merged 1 commit into from
Jan 27, 2018
Merged

build nuget packages after signing #4269

merged 1 commit into from
Jan 27, 2018

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Jan 25, 2018

Don't merge until the internal signed test build has completed.

Delay building the NuGet packages until after assembly signing has occurred.

Fixes #4263.

@brettfo brettfo force-pushed the nuget-sign branch 4 times, most recently from 5266760 to c23b9a4 Compare January 26, 2018 00:28
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brett, looks good

@brettfo brettfo changed the title build nuget packages after signing [WIP] build nuget packages after signing Jan 26, 2018
@brettfo brettfo changed the title [WIP] build nuget packages after signing build nuget packages after signing Jan 27, 2018
@brettfo brettfo merged commit 7c07673 into dev15.6 Jan 27, 2018
@brettfo brettfo deleted the nuget-sign branch January 27, 2018 01:16
brettfo added a commit that referenced this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants