Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #471 - consider QueryStartUpToDateCheck options, harden against sync context issues #479

Closed
wants to merge 1 commit into from
Closed

Fix #471 - consider QueryStartUpToDateCheck options, harden against sync context issues #479

wants to merge 1 commit into from

Conversation

latkin
Copy link
Contributor

@latkin latkin commented Jun 1, 2015

Shiproom template:

  • Bug number StartUpToDateCheck(null, 1) throws ArgumentException #471
  • Customer scenario VS extensions (e.g. TestDriven .NET) invoking F# project system StartUpToDateCheck get unexpected ArgumentException due to sync context issues.
  • Fix description
    • Use IVsSolutionBuildManager5.FindActiveProjectCfgName instead of IVsSolutionBuildManager2.FindActiveProjectCfg in TryGetActiveConfigurationAndPlatform, as it is not sensitive to sync context
    • Give proper consideration to the VSUTDCF options flags passed to QueryStartUpToDateCheck
  • Testing done Manual verification w/ TestDriven.NET + IDE unit tests

@latkin
Proper handling of VSUTDCF options in up-to-date check, and safer Try…
7b0a7ed 
…GetActiveConfigurationAndPlatform

 - Give proper consideration to the options flags passed to QueryStartUpToDateCheck
 - Use IVsSolutionBuildManager5.FindActiveProjectCfgName in TryGetActiveConfigurationAndPlatform, as it is not sensitive to sync context
   - Avoids exception for non-UI thread callers, e.g. DTEE automation

Fixes dotnet#471
@latkin
Copy link
Contributor Author

latkin commented Jun 2, 2015

Once again soliciting reviewers before I ask for approval at shiproom. /cc @enricosada @dungpa @KevinRansom etc

@latkin latkin removed the bar-check label Jun 2, 2015
@latkin latkin mentioned this pull request Jun 2, 2015
Closed
@MattGertz
Copy link

Approved 6/2 by ML Shiproom.

@latkin latkin closed this in 322d27f Jun 3, 2015
@latkin latkin added the fixed label Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@latkin @MattGertz @msftclas