Don't create dict for empty lists #5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Jul 18, 2018
KevinRansom
previously requested changes
Jul 18, 2018
|
Those failures don't really look related. Let's try again. @dotnet build test this |
|
@dotnet-bot test this please |
| @@ -405,10 +405,12 @@ namespace Microsoft.FSharp.Collections | |||
| loop 0 | |||
|
|
|||
| let inline groupByImpl (comparer:IEqualityComparer<'SafeKey>) (keyf:'T->'SafeKey) (getKey:'SafeKey->'Key) (array: 'T[]) = | |||
| let length = array.Length | |||
| if length = 0 then Microsoft.FSharp.Primitives.Basics.Array.zeroCreateUnchecked 0 else | |||
There was a problem hiding this comment.
Maybe it's time to add empty arrays singleton? #5066 (comment)
There was a problem hiding this comment.
yes. I could use them in many places
forki
changed the title
|
this is ready |
KevinRansom
approved these changes
Jul 19, 2018
cartermp
approved these changes
Jul 21, 2018
|
@forki thanks for this mate. |
Merged
|
@KevinRansom As mentioned in #5942 this is an incorrect optimization. We should revert and publish a new version of FSharp.Core assuming this has made it out into the wild (I think it has) |
|
ouch. apologies. @cartermp we also need some kind of test here |
KevinRansom
pushed a commit
that referenced
this pull request
Nov 26, 2018
* Fix and tests, unbuilt and untested * Correct one of the tests Got the order wrong for the output of `countBy`. * Repair the groupBy test groupBy test was bad: it assumed (ridiculously) that groupBy wouldn't iterate the original sequence even though it somehow knew the groups in the sequence.
KevinRansom
pushed a commit
to KevinRansom/fsharp
that referenced
this pull request
Nov 26, 2018
… (dotnet#5947) * Fix and tests, unbuilt and untested * Correct one of the tests Got the order wrong for the output of `countBy`. * Repair the groupBy test groupBy test was bad: it assumed (ridiculously) that groupBy wouldn't iterate the original sequence even though it somehow knew the groups in the sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in most other list operation implementations we should shortcut empty lists