Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master CI #5564

Merged
merged 2 commits into from Sep 5, 2018
Merged

Fix master CI #5564

merged 2 commits into from Sep 5, 2018

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Aug 28, 2018

This PR aims to get the CI building again for master branch.

  1. Adds a couple of binding redirects to some unit tests, because they rely on FSharp.Data which is compiled with an older version of FSharp.Core.dll

  2. <EnableFrameworkPathOverride>false</EnableFrameworkPathOverride>
    I don't know why this is required. I will need to find someone who can explain it. However, it appears to rely on
    "[Microsoft.Build.Utilities.ToolLocationHelper]::GetPathToStandardLibraries($(TargetFrameworkIdentifier), $(TargetFrameworkVersion), $(TargetFrameworkProfile), $(PlatformTarget), $(TargetFrameworkRootPath), $(TargetFrameworkFallbackSearchPaths))"

that has been removed from Microsoft.Build.Utilities.Core.dll.

So I think it must be an msbuild bug, but perhaps it is intentional.

Kevin

@cartermp
Copy link
Contributor

What is being "bumped"?

@KevinRansom KevinRansom changed the title bump Fix master CI Aug 28, 2018
@KevinRansom
Copy link
Member Author

@cartermp I have now changed the title, and added a description. The intent is to make the CI for master build again … somehow it got broke.

@brettfo
Copy link
Member

brettfo commented Aug 29, 2018

The latest failures look to be binding redirect issues for FSharp.Core:

018-08-29T01:35:08.9872831Z Project25 error: <<<The type provider 'ProviderImplementation.JsonProvider' reported an error: The type provider constructor has thrown an exception: Could not load file or assembly 'FSharp.Core, Version=4.3.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)>>>
2018-08-29T01:35:08.9873171Z Project25 error: <<<Referenced assembly 'D:\a\1\s\tests\service\data\FSharp.Data.dll' has assembly level attribute 'Microsoft.FSharp.Core.CompilerServices.TypeProviderAssemblyAttribute' but no public type provider classes were found>>>
2018-08-29T01:35:08.9873382Z Project25 error: <<<The type 'XmlProvider' is not defined.>>>
2018-08-29T01:35:08.9873516Z Project25 error: <<<The type 'XmlProvider' is not defined.>>>
2018-08-29T01:35:08.9873649Z Project25 error: <<<The field, constructor or member 'GetSample' is not defined.>>>
2018-08-29T01:35:08.9873794Z Project25 error: <<<The value or constructor 'XmlProvider' is not defined.>>>

@KevinRansom KevinRansom merged commit fbfbb00 into dotnet:master Sep 5, 2018
@KevinRansom KevinRansom deleted the bump branch September 5, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants