Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSharp.Core to netstandard2.0 #6771

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@KevinRansom
Copy link
Member

commented May 18, 2019

  1. FSharp.Core is updated to target netstandard2.0 as the minimum required platform.
  2. The FSharp.Core nuget package version 4.7.0, will contain net45 and netstandard2.0 dlls
    with the version number 4.7.0.0
  3. This PR enables the FSharpFunc API's that use the System.Converter class.
  4. Apparently the API Surface area tests have not been running, so I have re-enabled them, added back in the APIs that were missing. Some have moved around the baseline.

master will not be updated to a netstandard2.0 until after VS2019.2 has RTM'd

@KevinRansom KevinRansom requested review from brettfo and dsyme May 18, 2019

@cartermp

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2019

Link #1847

Show resolved Hide resolved src/fsharp/FSharp.Core/Testing.FSharp.Core.nuspec Outdated
@brettfo

This comment has been minimized.

Copy link
Member

commented May 18, 2019

(@KevinRansom CI isn't setup for this branch, do you want me to add it?)

@KevinRansom

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

@brettfo, yes please.

@KevinRansom KevinRansom reopened this May 19, 2019

@brettfo brettfo closed this May 20, 2019

@brettfo brettfo reopened this May 20, 2019

@brettfo brettfo closed this May 20, 2019

@brettfo brettfo reopened this May 20, 2019

<group targetFramework=".NETStandard2.0">
<dependency id="NETStandard.Library" version="2.0.3" />

This comment has been minimized.

Copy link
@cartermp

cartermp May 20, 2019

Collaborator

Is it necessary to specify this dependency explicitly?

@brettfo brettfo closed this May 20, 2019

@brettfo brettfo reopened this May 20, 2019

@brettfo brettfo closed this May 20, 2019

@brettfo brettfo reopened this May 20, 2019

@brettfo brettfo closed this May 20, 2019

@brettfo brettfo reopened this May 20, 2019

@brettfo brettfo closed this May 20, 2019

@brettfo brettfo reopened this May 20, 2019

KevinRansom added some commits May 20, 2019

@brettfo brettfo closed this May 21, 2019

@KevinRansom KevinRansom referenced this pull request May 22, 2019

Merged

Netstandard2 #6814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.