-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC FS-1068] open static classes #6807
Conversation
@dsyme Do the two TODOs make this a WIP? |
@cartermp Yes, though it should be very quick to resolve these and close this out. |
Tagging @TIHan for review |
src/buildfromsource/FSharp.Compiler.Interactive.Settings/InternalsVisibleTo.fs
Outdated
Show resolved
Hide resolved
vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.Completion.fs
Show resolved
Hide resolved
@cartermp @TIHan We have one remaining design issue for this feature, fsharp/fslang-design#352 (comment), basically |
I have resolved this (fsharp/fslang-design#352 (comment)), and this PR is now ready for review @KevinRansom @TIHan we need to add language version flag protection for this feature. What's our status for doing this? I'm happy to do it but it needs to be done ASAP Also should this go into |
@cartermp please re-review when you get the chance |
@KevinRansom @TIHan Please advise on adding the |
@dsyme if you have the time, feel free to guard this with the langversion switch without awaiting @KevinRansom. We're still getting our ducks in row for 16.3 :) |
929698e
to
e3262b3
Compare
e3262b3
to
607fa35
Compare
@KevinRansom @cartermp I rebased to |
…ure/open-static-classes
…atic-classes Merge master to feature/open-static-classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks fine code-wise, just a few minor questions above.
…704.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19354.2
…atic-classes Merge master to feature/open-static-classes
…705.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19355.2
…atic-classes Merge master to feature/open-static-classes
…706.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19356.1
…9c7-035f4f8673df [master] Update dependencies from dotnet/arcade
@KevinRansom I resolved the conflicts, you might want to double check |
Ugh I messed up the merge,
|
…atic-classes Merge master to feature/open-static-classes
We have a heisen-error in the Linux Source Build:
|
Continuation of #6309
Proof of concept for RFC FS-1068 Open static classes.
Details are on the RFC, but for example:
DONE:
AutoOpen
attributeRequireQualifiedNameAttribute(true)
on a static class, that prevents it being opened, or at least gives a warning, as for F# modules.open
vopen static