use Interlocked.Increment to be thread safe #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Nicely spotted too. |
| @@ -35,12 +35,12 @@ open Microsoft.FSharp.Core.CompilerServices | |||
| /// Unique name generator for stamps attached to lambdas and object expressions | |||
| type Unique = int64 | |||
| //++GLOBAL MUTABLE STATE | |||
There was a problem hiding this comment.
i think now are thread safe, should i remove the //++GLOBAL MUTABLE STATE too? /cc @dsyme
There was a problem hiding this comment.
Please change to //++GLOBAL MUTABLE STATE (thread safe)
|
It still is global mutable state, so the comment is not wrong. |
|
AFAIK these are not called in a multi-threaded way in VFT. But for FCS this should indeed be locked |
|
yes, i am trying to check all cache etc for thread safety, maybe we can unlock some parallelism in fsc |
KevinRansom
added a commit
that referenced
this pull request
Dec 12, 2015
use Interlocked.Increment to be thread safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed
newUniqueandnewStampto be safe to use as shared global generators