Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures, restoring tests matrix #812

Merged
merged 5 commits into from Dec 18, 2015
Merged

Fix test failures, restoring tests matrix #812

merged 5 commits into from Dec 18, 2015

Conversation

OmarTawfik
Copy link
Contributor

No description provided.

@enricosada
Copy link
Contributor

great job @otawfik-ms !

@enricosada
Copy link
Contributor

as a side node about build matrix:

fsharp suite (smoke)

Before parallelization After parallelization
22 min 15 min

and that's because there are some test, but few test directories ( parallelization work by directory ). full suite is faster than before!

Maybe we can run full fsharp suite ONLY when the commit is in master branch not pr, what do you think @KevinRansom?

@enricosada
Copy link
Contributor

btw @otawfik-ms , if you want you can do merge cambridge_suite and qa_suite in a single job

- BUILD_PROFILE: cambridge_suite,qa_suite,smoke_only

it's 7 minutes less ( the base download+compilation for a job is 7 minutes )

@OmarTawfik
Copy link
Contributor Author

@enricosada Strangely, it took more on my private build:
https://ci.appveyor.com/project/otawfik-ms/visualfsharp/build/0.0.1.8
I'll let it run for a few builds, and then combine them if they're consistently faster.

@KevinRansom
Copy link
Member

56 minutes for the verification --- kind of sucks.

@enricosada
Copy link
Contributor

The private build is oss ( or are you pro user? ) and run on a less powerful machine, i think. My private build for sure are slower

Inviato da Outlook Mobile

On Fri, Dec 18, 2015 at 11:01 AM -0800, "Omar Tawfik" notifications@github.com wrote:

@enricosada Strangely, it took more on my private build:
https://ci.appveyor.com/project/otawfik-ms/visualfsharp/build/0.0.1.8
I'll let it run for a few builds, and then combine them if they're consistently faster.


Reply to this email directly or view it on GitHub:
#812 (comment)

@enricosada
Copy link
Contributor

Maybe after coreclr we can use also the jenkins build servers.
Otherwise the only solution is buy another build worker = 25 min.

@enricosada
Copy link
Contributor

Is really funny. Appveyor run in azure 😄

@KevinRansom
Copy link
Member

@enrico OSS is the same as PRO just half price or at least it was at the time.

@KevinRansom
Copy link
Member

I am beginning to suspect though that our setup is not running on dedicated hardware like it should, instead it maybe running in the cloud.

@KevinRansom
Copy link
Member

Hmm!!!! Pro is one concurrent job, so no parallel jobs without the premium plan.

http://www.appveyor.com/pricing

Our current plan is : Pro FOSS

@OmarTawfik
Copy link
Contributor Author

@KevinRansom, actually, running in parallel with this speed means that we will be running all the tests (in this PR) in less than 30 minutes. I'm looking into all the options now to see if there is something we are missing.

@KevinRansom
Copy link
Member

I suppose 1 concurrent Job, could mean one job + another concurrently. It's not the way I would have read it. It would be great if we can run the jobs in parallel.

@KevinRansom
Copy link
Member

Okay we will pull this in, and we can work with it, while you figure out how to make it faster :-)

KevinRansom added a commit that referenced this pull request Dec 18, 2015
Fix test failures, restoring tests matrix
@KevinRansom KevinRansom merged commit fd4d36f into dotnet:master Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants