Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing number if isAppTy calls in NameRes #8285

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Reducing number if isAppTy calls in NameRes #8285

merged 1 commit into from
Jan 20, 2020

Conversation

forki
Copy link
Contributor

@forki forki commented Jan 19, 2020

No description provided.

TIHan
TIHan approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just curious what the reason is for making these changes? Perf and/or better code?

@forki
Copy link
Contributor Author

forki commented Jan 20, 2020

we introduced the ValueOption types in those tryDestAppTy and co a while ago to reduce the number of appty calls or more concrete to not call stripTyEqns and ultimately stripTyparEqnsAux over and over again.

@cartermp cartermp merged commit 6b18904 into dotnet:master Jan 20, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@forki @nosami
tryDestAppTy instead of isAppTy (dotnet#8285)
204c71e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TIHan TIHan TIHan approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@forki @TIHan @cartermp