perform sourceExpr translation on match-bang expressions #9407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
matchbang-source-translation
branch
2 times, most recently
from
4ff5da5
to
07c7397
Compare
|
Alright, this new test is green as well, so this one's ready for review too. |
|
@baronfel would you resolve the conflicts mate. Thanks KEvin |
KevinRansom
approved these changes
Jun 11, 2020
baronfel
force-pushed
the
matchbang-source-translation
branch
from
07c7397
to
13edf85
Compare
|
Ok, let's see if I factored out the tests correctly without typoing anything 🤞 |
|
Thanks m8 |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* perform sourceExpr translation on match-bang expressions * add test for match-bang source translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9406 by introducing sourceExpr rewriting for match! expressions.
I tested this locally using
dotnet run -f netcoreapp3.0 -- --langversion:preview /Users/chethusk/oss/scratch/match.fsxfrom the FSI directory and using the same failing fsx file from the issue report. I could use advice on how/where to add tests for this though. I imagine we'd need a miniature CE in the test suite to trigger this instead of bringing in an entire dependency.