Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: String.replicate from O(n) to O(log(n)), up to 12x speed improvement #9512

Merged
merged 6 commits into from Jun 27, 2020
Merged

Perf: String.replicate from O(n) to O(log(n)), up to 12x speed improvement #9512

merged 6 commits into from Jun 27, 2020

Commits on Jun 19, 2020

  1. Turn String.replicate from O(n) into O(log(n))

    @abelbraaksma
    abelbraaksma committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9de8799 View commit details
    Browse the repository at this point in the history

  2. Cleanup String.replicate tests by removing usages of "foo"

    @abelbraaksma
    abelbraaksma committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    739fe30 View commit details
    Browse the repository at this point in the history

  3. String.replicate: add tests for missing cases, and for the new O(log(… 

    …n)) cut-off points
    @abelbraaksma
    abelbraaksma committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9fdd920 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. Improve String.replicate algorithm further

    @abelbraaksma
    abelbraaksma committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    02abc25 View commit details
    Browse the repository at this point in the history

  2. Add tests for String.replicate covering all lines/branches of algo

    @abelbraaksma
    abelbraaksma committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    d7f7387 View commit details
    Browse the repository at this point in the history

  3. Fix accidental comment

    @abelbraaksma
    abelbraaksma committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    4f60f0b View commit details
    Browse the repository at this point in the history