Enable source path mapping for deteministic builds #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
mapsourceroots-build-task
branch
from
3be54ea
to
c13cb02
Compare
|
I haven't end to end tested compiling some stuff with the task, I wasn't sure if there were integration-style tests that used the targets to prove things like that. Ideally I'd sourcelink a library with this task, then use the sourcelink tool to dump the file paths and verify the correct deterministic paths are written. |
|
@baronfel , thanks for this, I'll try to look at this later in the week. Kevin |
KevinRansom
approved these changes
Aug 7, 2020
cartermp
approved these changes
Aug 7, 2020
|
Thanks @baronfel 😸 |
abelbraaksma
pushed a commit
to abelbraaksma/fsharp
that referenced
this pull request
Aug 9, 2020
* initial version * finish porting tests, last test fails * fix test * fix end tag * use cross-framework implementation of endsWithDirectorySeparator * UsingTask instead of fully-qualified names
14 tasks
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* initial version * finish porting tests, last test fails * fix test * fix end tag * use cross-framework implementation of endsWithDirectorySeparator * UsingTask instead of fully-qualified names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8883 by copying/translating the Roslyn build tasks for SourceRoot mapping, along with the test cases they have identified, into FSharp.Build. In addition this sets up the changes to the msbuild targets so that the new task is called at the appropriate point in the compilation so enable deterministic build path mappings.
In an ideal world we'd just be picking up and consuming the shared build task, but until that blessed time we must forge our own paths.