Skip to content

Commit

Permalink
Move to proper TargetFramework value
Browse files Browse the repository at this point in the history
  • Loading branch information
kant2002 committed Sep 1, 2020
1 parent ecebb9c commit aec9f9d
Show file tree
Hide file tree
Showing 25 changed files with 62 additions and 62 deletions.
2 changes: 1 addition & 1 deletion BUILDING.md
Expand Up @@ -68,7 +68,7 @@ There are three test assemblies in the solution:
- **TestPublic.dll** in the folder `test/TestPublic`.
- **Microsoft.ML.Probabilistic.Learners.Tests.dll** in the folder `test/Learners/LearnersTests`.

Depending on the build configuration and targeted framework, the assemblies will be located in the `bin/Debug<Core|Full>/<net50|net461>` or `bin/Release<Core|Full>/<net50|net461>` subdirectories
Depending on the build configuration and targeted framework, the assemblies will be located in the `bin/Debug<Core|Full>/<net5.0|net461>` or `bin/Release<Core|Full>/<net5.0|net461>` subdirectories
of the test project.

Runner executes tests in parallel by default. However, some test category must be run
Expand Down
2 changes: 1 addition & 1 deletion build/evaluator-netcore.yml
Expand Up @@ -14,6 +14,6 @@ steps:
inputs:
targetType: 'inline'
script: dotnet Evaluator.dll InferNetRunsOnly.xml
workingDirectory: ${{ format('src/Learners/Runners/Evaluator/bin/{0}/net50', parameters.Configuration) }}
workingDirectory: ${{ format('src/Learners/Runners/Evaluator/bin/{0}/net5.0', parameters.Configuration) }}
displayName: Running Evaluator
continueOnError: true
2 changes: 1 addition & 1 deletion docs/_build/makeApiDocs.ps1
Expand Up @@ -41,7 +41,7 @@ if (!(Test-Path $projPath)) {
& "$dotnetExe" build "$projPath" /p:Configuration=Release

Write-Host "Run PrepareSource for InferNet_Copy_Temp folder"
$prepareSourcePath = [IO.Path]::GetFullPath((join-path $sourceDirectory 'src/Tools/PrepareSource/bin/Release/net50/Microsoft.ML.Probabilistic.Tools.PrepareSource.dll'))
$prepareSourcePath = [IO.Path]::GetFullPath((join-path $sourceDirectory 'src/Tools/PrepareSource/bin/Release/net5.0/Microsoft.ML.Probabilistic.Tools.PrepareSource.dll'))
& "$dotnetExe" "$prepareSourcePath" "$destinationDirectory"

Write-Host "Install nuget package docfx.console"
Expand Down
6 changes: 3 additions & 3 deletions src/Examples/ClickThroughModel/ClickThroughModel.csproj
Expand Up @@ -17,17 +17,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/Examples/Crowdsourcing/Crowdsourcing.csproj
Expand Up @@ -17,17 +17,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
Expand Up @@ -16,17 +16,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/Examples/InferNET101/InferNET101.csproj
Expand Up @@ -16,17 +16,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/Examples/LDA/LDA.csproj
Expand Up @@ -18,17 +18,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/Examples/MotifFinder/MotifFinder.csproj
Expand Up @@ -18,17 +18,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/Examples/ReviewerCalibration/ReviewerCalibration.csproj
Expand Up @@ -17,17 +17,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
Expand Up @@ -16,17 +16,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/Learners/ClassifierModels/ClassifierModels.csproj
Expand Up @@ -19,19 +19,19 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
<!-- No need to generate code twice -->
<IgnorePostBuildNetCore>true</IgnorePostBuildNetCore>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
<RunPostBuildNetCore Condition="$(IgnorePostBuildNetCore) != 'true'">true</RunPostBuildNetCore>
</PropertyGroup>
Expand Down
6 changes: 3 additions & 3 deletions src/Learners/RecommenderModels/RecommenderModels.csproj
Expand Up @@ -19,19 +19,19 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
<!-- No need to generate code twice -->
<IgnorePostBuildNetCore>true</IgnorePostBuildNetCore>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
<RunPostBuildNetCore Condition="$(IgnorePostBuildNetCore) != 'true'">true</RunPostBuildNetCore>
</PropertyGroup>
Expand Down
6 changes: 3 additions & 3 deletions src/Learners/Runners/CommandLine/CommandLine.csproj
Expand Up @@ -18,17 +18,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/Learners/Runners/Evaluator/Evaluator.csproj
Expand Up @@ -18,17 +18,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/Tools/BuildFactorDoc/Tools.BuildFactorDoc.csproj
Expand Up @@ -3,7 +3,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
<RootNamespace>Microsoft.ML.Probabilistic.Tools.BuildFactorDoc</RootNamespace>
<AssemblyName>Microsoft.ML.Probabilistic.Tools.BuildFactorDoc</AssemblyName>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Tools/PrepareSource/Tools.PrepareSource.csproj
Expand Up @@ -3,7 +3,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
<AssemblyName>Microsoft.ML.Probabilistic.Tools.PrepareSource</AssemblyName>
<RootNamespace>Microsoft.ML.Probabilistic.Tools.PrepareSource</RootNamespace>
</PropertyGroup>
Expand Down
6 changes: 3 additions & 3 deletions src/Tutorials/Tutorials.csproj
Expand Up @@ -20,18 +20,18 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
<AddSyntheticProjectReferencesForSolutionDependencies>false</AddSyntheticProjectReferencesForSolutionDependencies>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions test/Learners/LearnersTests/LearnersTests.csproj
Expand Up @@ -15,17 +15,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions test/Learners/TestApp/TestApp.csproj
Expand Up @@ -18,17 +18,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions test/TestApp/TestApp.csproj
Expand Up @@ -20,17 +20,17 @@
</When>
<When Condition="'$(Configuration)'=='DebugCore' OR '$(Configuration)'=='ReleaseCore'">
<PropertyGroup>
<TargetFramework>net50</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<TargetFrameworks>net50;net461</TargetFrameworks>
<TargetFrameworks>net5.0;net461</TargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net50'">
<PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0'">
<DefineConstants>$(DefineConstants);NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>

Expand Down

0 comments on commit aec9f9d

Please sign in to comment.