Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET Core version #246

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Conversation

dsplaisted
Copy link
Member

Also add test to catch when ASP.NET depends on a later version than we have

Fixes https://github.com/dotnet/cli/issues/10553

@livarcocc livarcocc added this to the 3.0.1xx milestone Jan 7, 2019
Copy link

@livarcocc livarcocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for the smoke test.

@livarcocc
Copy link

@wfurt we are trying to update to the latest version of the runtime and this is now failing for freebsd only. Could you take a look?

@wfurt
Copy link
Member

wfurt commented Jan 7, 2019

It seems like something else changed as well. From the error log I see we are trying to download https://dotnetcli.azureedge.net/dotnet/Runtime/2.1.0/dotnet-runtime-2.1.0-freebsd-x64.tar.gz and that does notr exist for FreeBSD. Do you have any idea @livarcocc ? If not, I can dig into it.

@dsplaisted
Copy link
Member Author

@wfurt It's supposed to be OK for that download to fail (per the comment in the code at least):

https://github.com/dotnet/core-sdk/blob/master/eng/restore-toolset.sh#L16-L19

@wfurt
Copy link
Member

wfurt commented Jan 7, 2019

ok. Let me sync and do local test build on FreeBSD.
I did not build core-sdk for a while and it looks quite different than what I remember.

@wfurt
Copy link
Member

wfurt commented Jan 8, 2019

@rakeshsinghranchi
Copy link
Member

cc @dleeapho , @dagood , @mmitche

This is known for now as infrastructure issue. Azure devops machine pool doesn't have freebsd agent available.

@wfurt
Copy link
Member

wfurt commented Jan 8, 2019

can you use same pool as corefx and core-setup?

@rakeshsinghranchi
Copy link
Member

core-setup has moved to dnceng.visualstudio.com and I believe doesn't have access to those machine pools. @mmitche , @MattGal do you have any recommendation here ?

@wfurt
Copy link
Member

wfurt commented Jan 8, 2019

core-sdk also uses dceng
https://dnceng.visualstudio.com/internal/_build?definitionId=178

There may be more to that but:

- template: /eng/build.yml
  parameters:
    agentOs: FreeBSD
    queue: 
      name: dnceng-freebsd-internal
      timeoutInMinutes: 180
      matrix:
        Build_Release:
          _BuildConfig: Release
          _AdditionalBuildParameters: '/p:DisableSourceLink=true /p:DISABLE_CROSSGEN=true'

@rakeshsinghranchi
Copy link
Member

Cool. I wasn't aware of this new agent OS. Will give it a try. Thanks.

@livarcocc
Copy link

I am going to disable freebsd until we have runtime bits available for it again.

@livarcocc
Copy link

or rather, ask @dsplaisted to do it!

@livarcocc livarcocc merged commit 19cfda7 into dotnet:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants