generalise approach

dotnet · Feb 29, 2024 · 07977b2 · 07977b2
1 parent b6defd4
commit 07977b2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/src/Microsoft.DotNet.Interactive.SqlServer/MsSqlKernel.cs b/src/Microsoft.DotNet.Interactive.SqlServer/MsSqlKernel.cs
@@ -48,11 +48,6 @@ public override async Task ConnectAsync()
 
     protected override string CreateVariableDeclaration(string name, object value)
     {
-        if (value is PasswordString ps)
-        {
-            value = ps.GetClearTextPassword();
-        }
-
         return $"DECLARE @{name} {MapToSqlDataType(name, value)} = {MapToSqlValueDeclaration(value)};";
 
         static string MapToSqlDataType(string name, object value)
@@ -92,10 +87,6 @@ protected override bool CanDeclareVariable(string name, object value, out string
         msg = default;
         try
         {
-            if (value is PasswordString)
-            {
-                return true;
-            }
             SqlMetaData.InferFromValue(
                 value,
                 name);

diff --git a/src/Microsoft.DotNet.Interactive.SqlServer/ToolsServiceKernel.cs b/src/Microsoft.DotNet.Interactive.SqlServer/ToolsServiceKernel.cs
@@ -399,7 +399,14 @@ private string PrependVariableDeclarationsToCode(SubmitCode command, KernelInvoc
 
         foreach (var variableNameAndValue in _variables)
         {
-            var declareStatement = CreateVariableDeclaration(variableNameAndValue.Key, variableNameAndValue.Value);
+            var value = variableNameAndValue.Value;
+
+            if (value is PasswordString ps)
+            {
+                value = ps.GetClearTextPassword();
+            }
+
+            var declareStatement = CreateVariableDeclaration(variableNameAndValue.Key, value);
 
             var displayStatement = declareStatement;
 
@@ -442,6 +449,11 @@ private string PrependVariableDeclarationsToCode(SubmitCode command, KernelInvoc
                 throw new ArgumentNullException(nameof(value), $"Sharing null values is not supported at this time.");
             }
 
+            if (value is PasswordString ps)
+            {
+                value = ps.GetClearTextPassword();
+            }
+
             if (!CanDeclareVariable(name, value, out string msg))
             {
                 throw new ArgumentException($"Cannot support value of Type {value.GetType()}. {msg}");