Added support for no request nodes and just comments present (#3469)

* Added support for no request nodesand just comments * Addition of theory test for comments
dotnet · Feb 27, 2024 · 8e99f3e · 8e99f3e
1 parent 3ba37fe
commit 8e99f3e
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 1 deletion.
diff --git a/src/Microsoft.DotNet.Interactive.Http.Parsing/Parsing/HttpRequestParser.cs b/src/Microsoft.DotNet.Interactive.Http.Parsing/Parsing/HttpRequestParser.cs
@@ -77,6 +77,11 @@ public HttpSyntaxTree Parse()
                 }
             }
 
+            foreach (var comment in commentsToPrepend)
+            {
+                _syntaxTree.RootNode.Add(comment);
+            }
+
             return _syntaxTree;
         }
 
@@ -294,7 +299,7 @@ private void ConsumeCurrentTokenInto(HttpSyntaxNode node)
 
         private HttpRequestNode? ParseRequest()
         {
-            if (IsComment())
+            if (!MoreTokens() || IsComment())
             {
                 return null;
             }

diff --git a/src/Microsoft.DotNet.Interactive.Http.Parsing/Parsing/HttpRootSyntaxNode.cs b/src/Microsoft.DotNet.Interactive.Http.Parsing/Parsing/HttpRootSyntaxNode.cs
@@ -21,6 +21,11 @@ public void Add(HttpRequestNode requestNode)
         AddInternal(requestNode);
     }
 
+    public void Add(HttpCommentNode commentNode)
+    {
+        AddInternal(commentNode);
+    } 
+
     public void Add(HttpVariableDeclarationAndAssignmentNode variableNode)
     {
         AddInternal(variableNode);

diff --git a/src/Microsoft.DotNet.Interactive.Http.Tests/ParserTests.Comments.cs b/src/Microsoft.DotNet.Interactive.Http.Tests/ParserTests.Comments.cs
@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Management.Automation.Internal;
 using FluentAssertions;
 using Microsoft.DotNet.Interactive.Http.Parsing;
 using Microsoft.DotNet.Interactive.Http.Tests.Utility;
@@ -64,5 +65,43 @@ public void Comment_node_can_immediately_follow_headers()
                   .Should().ContainSingle<HttpCommentNode>()
                   .Which.Text.Should().Be("# This is a comment");
         }
+
+        [Theory]
+        [InlineData("""
+                # This is a comment
+                """)]
+        [InlineData("""
+                # This is a comment
+                # This is the second line of the comment
+                """)]
+        [InlineData("""
+                # This is a comment
+                # This is the second line of the comment
+                # This is the third line of the comment
+                """)]
+        [InlineData("""
+                GET https://example.com
+                # This is a comment
+                # This is the second line of the comment
+                """)]
+        [InlineData("""
+                # This is a comment
+
+                # This is the second line of the comment
+                """)]
+        [InlineData("""
+                # This is a comment
+
+                # This is the second line of the comment
+
+                # This is the third line of the comments
+                """)]
+        public void Comment_node_without_request_node_does_not_produce_diagnostics(string code)
+        {
+            var result = Parse(code);
+
+            result.GetDiagnostics().Should().BeEmpty();
+
+        }
     }
 }