Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to declared variables to support dynamic expressions #3450

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Change to declared variables to support dynamic expressions #3450

merged 5 commits into from
Feb 15, 2024

Conversation

bleaphar
Copy link
Contributor

This pr changes the declared variable definition to support dynamic expressions.

Summary

  • Moved the code for dynamic expression matching into a static class to be used in multiple locations
  • Added tests in the kernel and variables to target this scenario
  • Updated the bind function in request node to fix a stack overflow issue that was occurring with the circular reference

@jonsequitur jonsequitur merged commit a86a6ec into dotnet:main Feb 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsequitur jonsequitur jonsequitur approved these changes

Assignees
No one assigned
Labels
Area-HTTP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bleaphar @jonsequitur @colombod