Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package build control to CSharpProjectKernel #3498

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.Interactive.CSharp/CSharpKernel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ async Task IKernelCommandHandler<RequestSignatureHelp>.HandleAsync(RequestSignat

var document = _workspace.ForkDocumentForLanguageServices(command.Code);
var signatureHelp = await SignatureHelpGenerator.GenerateSignatureInformation(document, command, context.CancellationToken);
if (signatureHelp is { })
if (signatureHelp is not null)
{
context.Publish(signatureHelp);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System;
using Microsoft.DotNet.Interactive;
using Microsoft.DotNet.Interactive.CSharpProject;
using Xunit.Abstractions;

Expand All @@ -15,6 +16,7 @@ internal partial class LogEvents
new[]
{
typeof(LogEvents).Assembly,
typeof(ICodeRunner).Assembly
typeof(CSharpProjectKernel).Assembly,
typeof(Kernel).Assembly
});
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.Collections.Immutable;
using System.Linq;
using Microsoft.CodeAnalysis.Text;
using Microsoft.DotNet.Interactive.CSharpProject.Utility;
using Microsoft.DotNet.Interactive.Tests.Utility;
using Xunit;

namespace Microsoft.DotNet.Interactive.CSharpProject.Tests;
Expand Down

This file was deleted.

Loading