Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counterpart fix for #44973 - remove extra "src" folder level #308

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

trylek
Copy link
Member

@trylek trylek commented Dec 7, 2020

As discussed about two weeks back in context of

#304

this change complements the runtime repo PR

dotnet/runtime#44973

by fixing the correlated code in jitutils dealing with coreclr paths.

Thanks

Tomas

As discussed about two weeks back in context of

dotnet#304

this change complements the runtime repo PR

dotnet/runtime#44973

by fixing the correlated code in jitutils dealing with coreclr paths.

Thanks

Tomas
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple other places that might need changing:

(option.Contains("src/jit")

and:

"-header-filter=src/jit/.*",

I don't know what those do, but they look to assume a "src" directory immediate parent to "jit".

@kunalspathak
Copy link
Member

Good catch @BruceForstall.

@trylek
Copy link
Member Author

trylek commented Dec 7, 2020

Thanks Bruce, I have updated the two places you pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants