Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute stripping #103934

Open
MichalStrehovsky opened this issue Jun 3, 2021 · 2 comments
Open

Attribute stripping #103934

MichalStrehovsky opened this issue Jun 3, 2021 · 2 comments
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Milestone
10.0.0

Comments

@MichalStrehovsky
Copy link
Member

With #29723 looking more and more real, I think we need to think about how attribute stripping can be done safely.

Attribute stripping is currently the only optimization in illink that I know of that will break user code without any warnings.

I think it would be interesting if we could scope attribute stripping down to places where we can provably do it safely. Illink has a good idea of what members are going to be reflected on. We could limit attribute stripping to places that we know are not going to be reflected on. I think we could still get pretty decent savings and APIs like the proposed nullability info decoder would not get broken by illink.

Cc @vitek-karas
@marek-safar
Copy link
Contributor

Duplicate of dotnet/linker#1991

@marek-safar marek-safar marked this as a duplicate of dotnet/linker#1991 Jun 3, 2021
@MichalStrehovsky MichalStrehovsky mentioned this issue Jul 7, 2021
Merged
@sbomer sbomer mentioned this issue Jul 7, 2021
Closed
@MichalStrehovsky MichalStrehovsky mentioned this issue Jul 19, 2021
Closed
@MichalStrehovsky MichalStrehovsky mentioned this issue Oct 4, 2021
Merged
@MichalStrehovsky MichalStrehovsky mentioned this issue Nov 20, 2021
Merged
@MichalStrehovsky MichalStrehovsky mentioned this issue Feb 1, 2024
Open
@MichalStrehovsky MichalStrehovsky mentioned this issue Jun 4, 2024
Closed
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 24, 2024
@sbomer sbomer transferred this issue from dotnet/linker Jun 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 24, 2024
@sbomer sbomer added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 24, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@agocke agocke modified the milestones: Future, 10.0.0 Jun 28, 2024
@agocke agocke removed the untriaged New issue has not been triaged by the area owner label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
AppModel
Status: High Priority
Milestone
10.0.0
Development

No branches or pull requests
4 participants
@marek-safar @agocke @sbomer @MichalStrehovsky