Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/5.0] Mark generic arguments of dynamically accessed types #1637

Merged
merged 2 commits into from Nov 21, 2020
Merged

[release/5.0] Mark generic arguments of dynamically accessed types #1637

merged 2 commits into from Nov 21, 2020

Conversation

mateoatr
Copy link
Contributor

@mateoatr mateoatr commented Nov 19, 2020 •
edited by marek-safar

This PR mimics the behavior of #1566 without making use of the new type name parser introduced in #1472.

Fixes #1559

@mateoatr mateoatr mentioned this pull request Nov 19, 2020
Closed
vitek-karas
vitek-karas approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way it's very nicely targeted fix - should be much easier for servicing.

@marek-safar marek-safar added this to the .NET 5.0.x milestone Nov 20, 2020
@marek-safar marek-safar changed the title Mark generic arguments of dynamically accessed types [5.0] Mark generic arguments of dynamically accessed types Nov 20, 2020
@marek-safar marek-safar changed the title [5.0] Mark generic arguments of dynamically accessed types [release/5.0] Mark generic arguments of dynamically accessed types Nov 20, 2020
@marek-safar
Copy link
Contributor

please send a request to tactics for approval

@agocke
Copy link
Member

agocke commented Nov 21, 2020

Approved

@marek-safar marek-safar merged commit 19e5456 into dotnet:release/5.0 Nov 21, 2020
@vitek-karas vitek-karas mentioned this pull request Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marek-safar marek-safar marek-safar approved these changes

@vitek-karas vitek-karas vitek-karas approved these changes

@agocke agocke Awaiting requested review from agocke

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
.NET 5.0.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mateoatr @marek-safar @agocke @vitek-karas