Reenable default UnreachableBodies optimization #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whole runtime repo now passes with it and I could not repro xamarin issue locally. If this will turn out problem again it can now temporary disabled on per assembly basis.
|
Just curious - do we have any data on how many methods are affected when running linker in dotnet/runtime (on libraries)? |
vitek-karas
approved these changes
Feb 4, 2021
|
I ran it on one of the runtime pack build and only 3 assemblies were changed
|
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Whole runtime repo now passes with it and I could not repro xamarin issue locally. If this will turn out problem again it can now temporary disabled on per assembly basis. Commit migrated from dotnet/linker@15ab783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whole runtime repo now passes with it and I could not repro xamarin issue
locally. If this will turn out problem again it can now temporary disabled
on per assembly basis.