Preserve custom operators #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will keep custom operators on marked types whenever System.Linq.Expressions is used, and the operator input types are marked. The behavior is enabled by default, and can be disabled by passing --disable-operator-discovery. Addresses dotnet#1821
marek-safar
reviewed
Jul 2, 2021
- Avoid processing pending operators Dictionary if Linq.Expressions is unused - Allocate this possibly-unused Dictionary lazily - Use readonly field for always-used HashSet - Rename markOperators -> seenLinqExpressions - Clean up ProcessCustomOperators call to make intent more clear - Add comments - Check MetadataType.Int32 instead of searching BCL for Int32
sbomer
requested review from
MichalStrehovsky,
agocke,
vitek-karas and
marek-safar
vitek-karas
approved these changes
Jul 7, 2021
- seenLinqExpressions -> _seenLinqExpressions - use List for pending operators instead of HashSet
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Preserve custom operators This will keep custom operators on marked types whenever System.Linq.Expressions is used, and the operator input types are marked. The behavior is enabled by default, and can be disabled by passing --disable-operator-discovery. Addresses dotnet/linker#1821 * Fix behavior for operators on nullable types * Cleanup and PR feedback - Avoid processing pending operators Dictionary if Linq.Expressions is unused - Allocate this possibly-unused Dictionary lazily - Use readonly field for always-used HashSet - Rename markOperators -> seenLinqExpressions - Clean up ProcessCustomOperators call to make intent more clear - Add comments - Check MetadataType.Int32 instead of searching BCL for Int32 * Remove unnecessary parens * PR feedback - seenLinqExpressions -> _seenLinqExpressions - use List for pending operators instead of HashSet Commit migrated from dotnet/linker@6b0da00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will keep custom operators on marked types whenever System.Linq.Expressions
is used, and the operator input types are marked.
The behavior is enabled by default, and can be disabled by passing
--disable-operator-discovery.
Addresses #1821