Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated Windows pool in Azure Pipelines #2393

Merged
merged 2 commits into from Dec 1, 2021

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Nov 23, 2021

See https://github.com/dotnet/core-eng/issues/14783.

Also switch to latest macOS/Ubuntu/Windows vmImage.

@vitek-karas
Copy link
Member

Why can't we stay on the generic macOS image? I was hoping that would not have to deal with version deprecation if it's that way.

@akoeplinger
Copy link
Member Author

akoeplinger commented Nov 23, 2021

@vitek-karas that's fine too if you want to take the risk of Azure Pipelines updating the macOS version behind your back. In other repos we usually make it explicit and you're already using an explicit ubuntu-20.04 for example :)

@vitek-karas
Copy link
Member

@akoeplinger Just a personal opinion (I'll let Sven and Marek comment on this):

  • Linker doesn't have platform specific dependencies, so the Linux/macOS legs in CI are mostly to validate that it works cross-plat in general (like correct path handling and such)
  • Linker is consumed by several other repos which may upgrade to later versions of OSes any time, I would much prefer we catch any issues in this repo's CI, then waiting on the integration to other repos

As such I would prefer if we ran CI on the latest version of each OS. We seem to already do so for mac, we should do so for linux as well (and windows if that's possible).

@sbomer
Copy link
Member

sbomer commented Nov 29, 2021

Thanks!

Agreed, I would prefer to be on latest unless we have a good reason not to. It looks like they changed the recommended names so I would go with macOS-latest, windows-latest, and ubuntu-latest.

@akoeplinger
Copy link
Member Author

@sbomer done :)

@akoeplinger akoeplinger merged commit 2914e5a into main Dec 1, 2021
@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch December 1, 2021 14:14
@akoeplinger
Copy link
Member Author

@sbomer would you mind porting this to any applicable branches?

vitek-karas pushed a commit to vitek-karas/linker that referenced this pull request Dec 1, 2021
See dotnet/core-eng#14783.

Also switch to latest macOS/Ubuntu/Windows vmImage.
vitek-karas pushed a commit to vitek-karas/linker that referenced this pull request Dec 1, 2021
See dotnet/core-eng#14783.

Also switch to latest macOS/Ubuntu/Windows vmImage.
@vitek-karas
Copy link
Member

feature/damAnalyzer - #2412
release/6.0.2xx - #2413

Do we need anything else?

@sbomer
Copy link
Member

sbomer commented Dec 1, 2021

Thanks @vitek-karas I think those branches are enough. Not sure we need 5.0 and it's easy enough to do later if we need to spin a build.

vitek-karas added a commit that referenced this pull request Dec 1, 2021
See dotnet/core-eng#14783.

Also switch to latest macOS/Ubuntu/Windows vmImage.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
vitek-karas added a commit that referenced this pull request Dec 1, 2021
See dotnet/core-eng#14783.

Also switch to latest macOS/Ubuntu/Windows vmImage.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
See dotnet/core-eng#14783.

Also switch to latest macOS/Ubuntu/Windows vmImage.

Commit migrated from dotnet/linker@2914e5a
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
… (dotnet/linker#2412)

See dotnet/core-eng#14783.

Also switch to latest macOS/Ubuntu/Windows vmImage.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

Commit migrated from dotnet/linker@1eeb126
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
… (dotnet/linker#2413)

See dotnet/core-eng#14783.

Also switch to latest macOS/Ubuntu/Windows vmImage.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

Commit migrated from dotnet/linker@25f850c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants