Add tests for out and ref parameter data flow #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlakollo
reviewed
Feb 18, 2022
| [ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValue))] | ||
| [ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValue))] | ||
| // https://github.com/dotnet/linker/issues/2632 | ||
| // This second warning should not be generated, the value of typeWithMethods should have PublicMethods |
tlakollo
reviewed
Feb 18, 2022
| typeWithMethods.RequiresPublicMethods (); | ||
| } | ||
|
|
||
| [ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValue))] |
There was a problem hiding this comment.
nit: TryGetAnnotatedValueFromValue to be consistent, not actually important from the standpoint of the testing infra
tlakollo
reviewed
Feb 18, 2022
| [ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValue))] | ||
| // https://github.com/dotnet/linker/issues/2632 | ||
| // This second warning should not be generated, the value of typeWithMethods should have PublicMethods | ||
| // after the call with out parameter. |
tlakollo
reviewed
Feb 18, 2022
| [ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValue))] | ||
| [ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValue))] | ||
| // https://github.com/dotnet/linker/issues/2632 | ||
| // This second warning should not be generated, the value of typeWithMethods should have PublicMethods |
tlakollo
approved these changes
Feb 18, 2022
vitek-karas
force-pushed
the
AddOutParamTests
branch
from
434f585
to
d658b31
Compare
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for dotnet/runtime#101734