Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pigsty for VarVector doesn't have hash one hot #1225

Closed
rauhs opened this issue Oct 11, 2018 · 1 comment
Closed

Pigsty for VarVector doesn't have hash one hot #1225

rauhs opened this issue Oct 11, 2018 · 1 comment
Assignees
Labels
bug Something isn't working
Projects

Comments

@rauhs
Copy link
Contributor

rauhs commented Oct 11, 2018

I'm trying to convert my LearningPipeline to 0.6 static pipeline. I have some variable length features in my input instances.

With the pipeline I did:

new CategoricalHashOneHotVectorizer(nameof(TransportOrderInstance.PosAmount)) { OutputKind = CategoricalTransformOutputKind.Bag, Ordered = false, HashBits = 5},

What is the equivalent in the new static pipeline? The VarVector doesn't have a whole lot of extension functions. Shouldn't it also have OneHotEncoding? Though, it's not "One" necessarily.

@Zruty0 Zruty0 added the bug Something isn't working label Oct 12, 2018
@Zruty0
Copy link
Contributor

Zruty0 commented Oct 12, 2018

This looks like an oversight on our part. We have OneHotHashEncoding for scalar and vector, but not for VarVector.

You can use CategoricalHashEstimator directly (via the dynamic API) until we fix that.

@Zruty0 Zruty0 added this to To Do in v0.7 Oct 15, 2018
@shauheen shauheen removed this from To Do in v0.7 Nov 1, 2018
@shauheen shauheen added this to To do in v0.8 Nov 1, 2018
@shmoradims shmoradims self-assigned this Nov 27, 2018
@shmoradims shmoradims moved this from To do to In progress in v0.8 Nov 27, 2018
v0.8 automation moved this from In progress to Done Nov 28, 2018
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
v0.8
  
Done
Development

No branches or pull requests

3 participants