Added VarVector static extension for OneHotHashEncoding #1745
+38
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogancarr
reviewed
Nov 28, 2018
| C: row.VectorString.OneHotHashEncoding(outputKind: CategoricalHashStaticExtensions.OneHotHashVectorOutputKind.Bag), | ||
| D: row.ScalarString.OneHotHashEncoding(outputKind: CategoricalHashStaticExtensions.OneHotHashScalarOutputKind.Bin), | ||
| E: row.VectorString.OneHotHashEncoding(outputKind: CategoricalHashStaticExtensions.OneHotHashVectorOutputKind.Bin), | ||
| F: row.VarVectorString.OneHotHashEncoding() |
Contributor
There was a problem hiding this comment.
Do you need to test any variations in input parameters? #Resolved
Author
There was a problem hiding this comment.
The default is Bag which works and makes sense. For Ind, the output makes sense for Vector but I don't think it makes sense for VarVector. It would be variable vectors of indicators, which can't be fed into a learner and I can't think of another transform to use it.
In reply to: 236895571 [](ancestors = 236895571)
rogancarr
approved these changes
Nov 28, 2018
Contributor
rogancarr
left a comment
rogancarr
left a comment
There was a problem hiding this comment.
Approved with a question above.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1225