Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Binary classification evaluator configurable #1251

Closed
Zruty0 opened this issue Oct 13, 2018 · 2 comments
Closed

Make Binary classification evaluator configurable #1251

Zruty0 opened this issue Oct 13, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Oct 13, 2018

The following method:

        public BinaryClassifierEvaluator.CalibratedResult Evaluate(IDataView data, string label = DefaultColumnNames.Label, string score = DefaultColumnNames.Score,
            string probability = DefaultColumnNames.Probability, string predictedLabel = DefaultColumnNames.PredictedLabel)

needs to expose additional parameters from BinaryClassifierEvaluator.Arguments, or a delegate to set them.

@Zruty0 Zruty0 added enhancement New feature or request up-for-grabs A good issue to fix if you are trying to contribute to the project labels Oct 13, 2018
@SebHel
Copy link

SebHel commented Oct 18, 2018

I would like to have a go at this. So the relevant Evaluate method should have a BinaryClassifierEvaluator.Arguments as an additional parameter and we use it to set the private fields

private readonly Single _threshold; private readonly bool _useRaw; private readonly int _prCount; private readonly int _aucCount; private readonly int _auPrcCount; ?

In this case we might want to get rid of the Arguments args parameter in the constructor of BinaryClassifierEvaluator?

@abgoswam abgoswam self-assigned this Dec 23, 2018
@abgoswam abgoswam removed the up-for-grabs A good issue to fix if you are trying to contribute to the project label Dec 23, 2018
@artidoro
Copy link
Contributor

artidoro commented Jul 2, 2019

We have internalized that method so I think we can close this issue.

@artidoro artidoro closed this as completed Jul 2, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants