Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Samples/UCI and ZBaseline Folders to Test/Data Folder #4

Closed
KrzysztofCwalina opened this issue May 4, 2018 · 6 comments · Fixed by #263
Closed

Move Samples/UCI and ZBaseline Folders to Test/Data Folder #4

KrzysztofCwalina opened this issue May 4, 2018 · 6 comments · Fixed by #263
Labels
up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
Milestone

Comments

@KrzysztofCwalina
Copy link
Member

These folders should not be in the root of the repo.

@glebuk
Copy link
Contributor

glebuk commented May 4, 2018

Please also rename documentation folder to docs

@shauheen shauheen added the up-for-grabs A good issue to fix if you are trying to contribute to the project label May 9, 2018
@shauheen shauheen added this to Backlog in v0.2 via automation May 9, 2018
@shauheen shauheen added this to the 0518 milestone May 9, 2018
@Niladri24dutta
Copy link
Contributor

I can take up this task, should I create a PR for this?

@shauheen
Copy link
Contributor

Thanks @Niladri24dutta, that would be great. Please also take a look at the discussion in #100 where the Baseline folder was discussed by @TomFinley and others, and let us know if you have any questions. I think we would want to move ZBaseline to /test/BaselineOutput. @KrzysztofCwalina any objections?

@KrzysztofCwalina
Copy link
Member Author

No objections

zeahmed referenced this issue in zeahmed/machinelearning May 24, 2018
@rantri
Copy link
Contributor

rantri commented May 29, 2018

Hi,
Can I take this issue?
I already moved the files in "ZBaselines" to "test/BaselineOutput".
Should I move the files in "Samples/UCI" to "test/data" or "test/data/UCI" or "test/data/Samples/UCI"?

@shauheen
Copy link
Contributor

Hi @rantri, that would be great. I think it should be moved to "test/data" for now.

v0.2 automation moved this from Backlog to Done May 29, 2018
ericstj pushed a commit to ericstj/machinelearning that referenced this issue Aug 24, 2018
Merge with latest dotnet/master
sayanshaw24 pushed a commit to sayanshaw24/machinelearning that referenced this issue Aug 14, 2019
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
No open projects
v0.2
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants