Onnxtransform - api changes for GPU support #1922
Conversation
jignparm
changed the title
build/Dependencies.props
Outdated
| @@ -15,7 +15,7 @@ | |||
| <PropertyGroup> | |||
| <GoogleProtobufPackageVersion>3.5.1</GoogleProtobufPackageVersion> | |||
| <LightGBMPackageVersion>2.2.1.1</LightGBMPackageVersion> | |||
| <MicrosoftMLOnnxRuntimePackageVersion>0.1.5</MicrosoftMLOnnxRuntimePackageVersion> | |||
| <MicrosoftMLOnnxRuntimeGpuPackageVersion>0.1.5-dev-11e91b61</MicrosoftMLOnnxRuntimeGpuPackageVersion> | |||
There was a problem hiding this comment.
0.1.5-dev-11e91b61< [](start = 44, length = 20)
double-checking that it is desired to go with a dev version for 0.9
There was a problem hiding this comment.
This is not the final package to use. The merge with master will contain the official onnxruntime package. This package is used for testing the CI build only.
| return Create(env, args, input); | ||
| } | ||
|
|
||
| public static IDataTransform Create(IHostEnvironment env, IDataView input, string modelFile, string[] inputColumns, string[] outputColumns) | ||
| public static IDataTransform Create(IHostEnvironment env, IDataView input, string modelFile, string[] inputColumns, string[] outputColumns, int gpuDeviceId = -1, bool fallbackToCpu = false) |
There was a problem hiding this comment.
public [](start = 8, length = 6)
can all Create method be made non-public, preferably private? #Closed
There was a problem hiding this comment.
Create was used previously as a public method in MLnet examples and tests. Has that changed? I thought Create() was a typically way to create a transform in a pipeline. There's been so many API changes however, that it may not be the case any longer.
There was a problem hiding this comment.
I believe the tendency is to use the constructors to instantiate, and leave the static Create methods for the reflection-based component catalog approach if you don't have a private constructor with just environment and arguments (matching the signature. ) If that is their only purpose, they can be private. we;'re being picky on this because everything public gets picked up by the docs site.
In reply to: 243467291 [](ancestors = 243467291)
| @@ -48,6 +48,13 @@ namespace Microsoft.ML.Transforms | |||
| /// <p>Supports inferencing of models in 1.2 and 1.3 format, using the | |||
| /// <a href='https://www.nuget.org/packages/Microsoft.ML.OnnxRuntime/'>Microsoft.ML.OnnxRuntime</a> library | |||
There was a problem hiding this comment.
Microsoft.ML.OnnxRuntime [](start = 8, length = 95)
not anymore, right?
There was a problem hiding this comment.
It will still be OnnxRuntime -- this package is only for testing the CI build . There will be a commit before merge with master to switch back to OnnxRuntime.
ghost
locked as resolved and limited conversation to collaborators
Fixes #1834
Add CUDA 10.0 GPU execution support
Add Linux support
Add Mac support