Remove "KeyType" specific members on ColumnType. #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
commented
Jan 7, 2019
artidoro
reviewed
Jan 8, 2019
artidoro
reviewed
Jan 8, 2019
sfilipi
reviewed
Jan 8, 2019
sfilipi
reviewed
Jan 8, 2019
sfilipi
reviewed
Jan 8, 2019
- IsKey - KeyCount - KeyCountCore Part of the work necessary for dotnet#1860 and contributes to dotnet#1533.
- Rename KeyType extension method to be a verb - Simplify check.
eerhardt
force-pushed
the
ColumnTypeKey
branch
from
a7742c2
to
f266463
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the following members from ColumnType:
Part of the work necessary for #1860 and contributes to #1533.