Removed python naming conventions from C# samples #2203
Conversation
|
|
| var transformedData_default = default_pipeline.Fit(trainData).Transform(trainData); | ||
| var transformedData_customized = customized_pipeline.Fit(trainData).Transform(trainData); | ||
| var transformedDataDefault = defaultPipeline.Fit(trainData).Transform(trainData); | ||
| var transformedDatacustomized = customizedPipeline.Fit(trainData).Transform(trainData); |
There was a problem hiding this comment.
transformedDataCustomized
| @@ -10,23 +10,23 @@ public class MatrixFactorizationExample | |||
| // The variable _synthesizedMatrixFirstRowIndex indicates the integer that would be mapped to the first row index. If user data uses | |||
| // 0-based indices for rows, _synthesizedMatrixFirstRowIndex can be set to 0. Similarly, for 1-based indices, _synthesizedMatrixFirstRowIndex | |||
| // could be 1. | |||
| const int _synthesizedMatrixFirstColumnIndex = 1; | |||
There was a problem hiding this comment.
Let's keep these with the underscore (_), but mark them private.
There was a problem hiding this comment.
Ok I didn't think any names should have an underscore regardless of access
There was a problem hiding this comment.
The convention we follow is that private variables start with underscores and public variables start with caps.
| @@ -33,8 +33,8 @@ public static void NgramTransform() | |||
| var twoCharsPipeline = charsPipeline.Append(ngramTwpPipeline); | |||
|
|
|||
| // The transformed data for pipelines. | |||
| var transformedData_onechars = oneCharsPipeline.Fit(trainData).Transform(trainData); | |||
| var transformedData_twochars = twoCharsPipeline.Fit(trainData).Transform(trainData); | |||
| var transformedDataOnechars = oneCharsPipeline.Fit(trainData).Transform(trainData); | |||
| var twoCharsPipeline = charsPipeline.Append(ngramTwpPipeline); | ||
|
|
||
| // The transformed data for pipelines. | ||
| var transformedData_onechars = oneCharsPipeline.Fit(trainData).Transform(trainData); | ||
| var transformedData_twochars = twoCharsPipeline.Fit(trainData).Transform(trainData); | ||
| var transformedDataOnechar = oneCharPipeline.Fit(trainData).Transform(trainData); |
|
@daniel-loudon Do you have plans to update this PR to latest master and resolve conflicts? |
|
@daniel-loudon Thank you for updating this PR.
That doesn't look like proper merge with latest master. |
Yeah something didnt go right with my upstream, shall I try again? |
ghost
closed this
|
I will redo this in the morning and open a new PR, I couldn't fetch any commits from this respository. Is that cool? I only learn from my mistakes. |
|
@daniel-loudon No worries. |
Fixes #2155
Removed the python naming conventions in
docs/samples/Microsoft.ML.Samples