Remove unnecessary finalizer #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LatentDirichletAllocationTransformer does not directly own any unmanaged resources, so it does not need a finalizer.
Codecov Report
@@ Coverage Diff @@
## master #4621 +/- ##
==========================================
- Coverage 75.66% 75.64% -0.02%
==========================================
Files 938 938
Lines 168623 168615 -8
Branches 18206 18205 -1
==========================================
- Hits 127582 127543 -39
- Misses 36005 36039 +34
+ Partials 5036 5033 -3
|
eerhardt
approved these changes
Jan 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LatentDirichletAllocationTransformer does not directly own any unmanaged resources, so it does not need a finalizer.