Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve logging for Functional Tests #4814

Merged
merged 1 commit into from Feb 8, 2020
Merged

improve logging for Functional Tests #4814

merged 1 commit into from Feb 8, 2020

Conversation

frank-dong-ms-zz
Copy link
Contributor

Better logging for FT:

  1. add test output logging handler and MessageKindToLog in FT base class
  2. move TestLogger to TestFrameworkCommon project as this is more common test project and we might need to use TestLogger in future for FT

@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner February 7, 2020 23:27
harishsk
harishsk approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frank-dong-ms-zz frank-dong-ms-zz merged commit 6b6f04b into dotnet:master Feb 8, 2020
@frank-dong-ms-zz frank-dong-ms-zz deleted the baseFTSync branch April 15, 2020 20:36
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harishsk harishsk harishsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frank-dong-ms-zz @harishsk