Enable FxCop on all projects #5331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Sdl.Required.Warning.ruleset
antoniovs1029
changed the title
12 tasks
antoniovs1029
commented
Jul 31, 2020
Comment on lines
+16
to
+17
| <!-- <Rule Id="CA1063" Action="Warning" /> Disable. Don't Fix --> | ||
| <!-- <Rule Id="CA1065" Action="Warning" /> Disable. Might Fix --> |
There was a problem hiding this comment.
The rules that are disabled on this file correspond to what is described on #5334
Codecov Report
@@ Coverage Diff @@
## master #5331 +/- ##
==========================================
+ Coverage 73.97% 74.04% +0.07%
==========================================
Files 1019 1019
Lines 189949 189949
Branches 20429 20429
==========================================
+ Hits 140506 140639 +133
+ Misses 43914 43797 -117
+ Partials 5529 5513 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
harishsk
approved these changes
Aug 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables de FxCop Analyzers on all projects of ML.NET using the
Sdl.Required.Warning.rulesetrecommended to us offline.NOTE: Right after enabling the FxCop Analyzers (i.e. when syncing with this branch), I've found necessary to Clean, Close, Clean and Rebuild the ML.NET Visual Studio solution to make the changes effective.